Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

724 improve plot #753

Merged
merged 3 commits into from
Apr 14, 2023
Merged

724 improve plot #753

merged 3 commits into from
Apr 14, 2023

Conversation

chlebowa
Copy link
Contributor

Fixes #724.

Changed default value of plot_width argument to achieve a better initial layout.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit f8007cb.

♻️ This comment has been updated with latest results.

@chlebowa chlebowa requested review from Melkiades and BLAZEWIM April 12, 2023 14:01
BLAZEWIM
BLAZEWIM approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@BLAZEWIM BLAZEWIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Melkiades
Melkiades approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I think we would eventually need to be able to modify these values from the front-end but surely it is for the future. Thanks @chlebowa

@chlebowa
Copy link
Contributor Author

Lgtm! I think we would eventually need to be able to modify these values from the front-end but surely it is for the future. Thanks @chlebowa

You can, actually, with the two expand icons. One of them only takes effect in the resulting report, though. To make it more obvious would be a teal.widgets issue.

@chlebowa chlebowa merged commit 69cb2f3 into main Apr 14, 2023
@chlebowa chlebowa deleted the 724_widen_plot@main branch April 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@BLAZEWIM BLAZEWIM BLAZEWIM approved these changes

Assignees
No one assigned
Labels
core sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too wide/unstructured display for tm_g_forest_rsp
3 participants
@chlebowa @Melkiades @BLAZEWIM