Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up example data modification #739

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Mar 6, 2023

Also capitalized all module labels.

Closes #735

@edelarua edelarua added the sme label Mar 6, 2023
@edelarua edelarua enabled auto-merge (squash) March 6, 2023 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Unit Tests Summary

    1 files    33 suites   2s ⏱️
149 tests 149 ✔️     0 💤 0
280 runs  168 ✔️ 112 💤 0

Results for commit 47b6a12.

♻️ This comment has been updated with latest results.

@@ -778,8 +778,10 @@ template_events_col_by_grade <- function(dataname,
#' @export
#' @examples
#' adsl <- tmc_ex_adsl
#' lbls_adae <- formatters::var_labels(tmc_ex_adae)
#' adae <- tmc_ex_adae %>%
#' dplyr::mutate_if(is.character, as.factor) # be certain of having factors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this step drop labels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shajoezhu yes, whenever mutate is used on a column the label is dropped.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua

@edelarua edelarua merged commit e686207 into main Mar 7, 2023
@edelarua edelarua deleted the 735_example_data_mods@main branch March 7, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix data modification in examples
2 participants