-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix faceting in tm_g_km
#720
Conversation
I believe dropping unused levels is sufficient here as it results in no empty subplots taking up space. In a reasonable majority of cases the faceting variable will have few values. In the minority of cases with many values, I believe the recommended solution is to manually change the plot size using the widgets in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some changes:
- Pushed the dropping of the empty levels one level up
- removed the condition for empty plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree with @chlebowa that the user shall manually update the height of the plots as he/she desires and it is not the responsibility of the module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But not in the app 🤔 |
Introduced counting function again. Seems to work well now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Closes #665.
Added expression that drops unused levels of faceting variable before plotting, so that empty panels are not plotted.