Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qenv warnings #621

Merged
merged 14 commits into from
Oct 27, 2022
Merged

qenv warnings #621

merged 14 commits into from
Oct 27, 2022

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 commented Sep 29, 2022 •
edited
Loading

@mhallal1 mhallal1 added the core label Sep 29, 2022
@mhallal1 mhallal1 changed the base branch from main to teal_refactor@main September 29, 2022 09:57
This was referenced Sep 29, 2022
Merged
Merged
Closed
mhallal1 and others added 6 commits September 29, 2022 16:20
@mhallal1
Apply suggestions from code review
d6f58d8 
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
@mhallal1
Update R/tm_g_pp_adverse_events.R
a5e3ef7 
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
Signed-off-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
fix km plot
ad116d9
@mhallal1
correct names
401bd8d
@mhallal1
fix tm_t_tte
d22b3e0
@mhallal1
fixes
db589f5
@donyunardi donyunardi mentioned this pull request Oct 7, 2022
Closed
21 tasks
gogonzo
gogonzo reviewed Oct 27, 2022
View reviewed changes
R/tm_g_km.R Outdated Show resolved Hide resolved
gogonzo
gogonzo reviewed Oct 27, 2022
View reviewed changes
R/tm_g_pp_vitals.R Outdated Show resolved Hide resolved
gogonzo
gogonzo reviewed Oct 27, 2022
View reviewed changes
R/tm_t_binary_outcome.R Outdated Show resolved Hide resolved
gogonzo
gogonzo reviewed Oct 27, 2022
View reviewed changes
R/tm_t_tte.R Outdated Show resolved Hide resolved
@gogonzo
Apply suggestions from code review
53c6384 
Simplify if conditions

Signed-off-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
gogonzo
gogonzo approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@nikolas-burkoff nikolas-burkoff merged commit 3834ac2 into teal_refactor@main Oct 27, 2022
@nikolas-burkoff nikolas-burkoff deleted the 63_warnings@teal_refactor@main branch October 27, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas-burkoff nikolas-burkoff nikolas-burkoff left review comments

@gogonzo gogonzo gogonzo approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhallal1 @gogonzo @nikolas-burkoff