Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 Update tm_a_mmrm column name #601

Merged
merged 6 commits into from
Sep 19, 2022
Merged

11 Update tm_a_mmrm column name #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6541869
Update col name
edelarua Sep 16, 2022
5cba002
Merge 6541869db71d89f6bdc1fd67a35e59f3f8f4c1fe into 697afbf1f253efd66…
edelarua Sep 16, 2022
ed3b499
[skip actions] Restyle files
github-actions[bot] Sep 16, 2022
56a68b3
Update tests
edelarua Sep 16, 2022
5299a66
Merge remote-tracking branch 'origin/11_update_tm_a_mmrm_colname@main…
edelarua Sep 16, 2022
cf6b4c9
Merge branch 'main' into 11_update_tm_a_mmrm_colname@main
edelarua Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* Enhanced the `tm_t_pp_medical_history` module to use the `table_with_settings` module and return the `rtables` object.
* Implemented `nestcolor` in examples, refactored `tm_g_barchart_simple` to allow use of `nestcolor`.
* Added more descriptive title/labels to `tm_g_ci`.
* Updated `tm_a_mmrm` column name when no treatment is selected from "all obs" to "All Patients".

### Bug fixes

Expand Down
3 changes: 2 additions & 1 deletion R/tm_a_mmrm.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ template_mmrm_tables <- function(parentname,
layout_list,
substitute(
expr =
rtables::split_rows_by(visit_var) %>%
rtables::add_overall_col("All Patients") %>%
rtables::split_rows_by(visit_var) %>%
tern.mmrm::summarize_lsmeans(arms = FALSE) %>%
rtables::append_topleft(paste0(" ", paramcd)),
env = list(
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-tm_a_mmrm.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ testthat::test_that("template_mmrm_tables works as expected when arm is not cons
expected <- list(
layout = quote(
lyt <- rtables::basic_table() %>%
rtables::add_overall_col("All Patients") %>%
rtables::split_rows_by("AVISIT") %>%
tern.mmrm::summarize_lsmeans(
arms = FALSE
Expand Down