-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
26 new chunks@main #540
26 new chunks@main #540
Conversation
|
* quosure * merged_data to merge_inputs - two modules Co-authored-by: Mahmoud Hallal <mahmoud.hallal@roche.com>
|
* apply quosures
coverage of tmc modules in the teal.gallery (tmc related apps, the same result for all apps
|
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
R/tm_t_abnormality.R
Outdated
# Update UI choices depending on selection of previous options | ||
shiny::observeEvent(input$grade, { | ||
anl <- datasets$get_data(dataname, filtered = FALSE) | ||
anl <- data[[dataname]]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume having filtered data instead of unfiltered here is OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfiltered is ok but what's happening in this observer is funny. observeEvent can't return anything and also you can't pass the validate statement further - this means that observeEvent is completelly redundant here.
) | ||
|
||
data_chunk <- shiny::reactive({ | ||
merged_data_q <- shiny::reactive({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the last comment, the previous comments have been addressed and the apps retested with filters --> LGTM.
fixes:
See the quosure PR
insightsengineering/teal.code#49
App with fixed modules