Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix barchart #524

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix barchart #524

merged 1 commit into from
Jun 30, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

Follow on from #521

It sporadically failed for me even after the above PR, so this should fix it @donyunardi

@nikolas-burkoff nikolas-burkoff mentioned this pull request Jun 30, 2022
Closed
Polkas
Polkas approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @export has to work now:)

@nikolas-burkoff nikolas-burkoff linked an issue Jun 30, 2022 that may be closed by this pull request
tmc getting started vignette is broken #520
Closed
@Polkas Polkas self-assigned this Jun 30, 2022
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    32 suites   9s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
155 runs  155 ✔️ 0 💤 0 ❌

Results for commit 7ea11a9.

@nikolas-burkoff nikolas-burkoff merged commit e80ea2e into main Jun 30, 2022
@nikolas-burkoff nikolas-burkoff deleted the 520_fix2@main branch June 30, 2022 09:01
@donyunardi
Copy link
Contributor

It works! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polkas Polkas Polkas approved these changes

@mhallal1 mhallal1 Awaiting requested review from mhallal1

Assignees

@Polkas Polkas

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tmc getting started vignette is broken
3 participants
@nikolas-burkoff @donyunardi @Polkas