Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename output IDE to prevent DOM conflicts #1114

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Rename output IDE to prevent DOM conflicts #1114

merged 5 commits into from
Apr 10, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Apr 9, 2024 •
edited
Loading

Pull Request

Fixes #1044

Changes description

  • Rename output ID

Note: I don't think this is NEWS.md noteworthy.

@averissimo averissimo added the core label Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited
Loading

Unit Tests Summary

  1 files   33 suites   3s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 2685e35.

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar self-assigned this Apr 10, 2024
kartikeyakirar
kartikeyakirar approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 duplicate input and output ids is resolved.

@averissimo averissimo merged commit b1ac512 into main Apr 10, 2024
21 checks passed
@averissimo averissimo deleted the 1044-fix-unique-id@main branch April 10, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@kartikeyakirar kartikeyakirar

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tm_t_logistic shinytest2 warning
2 participants
@averissimo @kartikeyakirar