Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use of deprecated strat argument from tern #1081

Merged
merged 9 commits into from
Feb 28, 2024
Merged

Update use of deprecated strat argument from tern #1081

merged 9 commits into from
Feb 28, 2024

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #1080

@edelarua edelarua added the sme label Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024 •
edited
Loading

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 1bb220a.

♻️ This comment has been updated with latest results.

@edelarua edelarua added blocked and removed blocked labels Feb 23, 2024
shajoezhu
shajoezhu previously requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @edelarua , thanks for the changes! can you update the news please. Thanks!

@shajoezhu shajoezhu self-assigned this Feb 26, 2024
@pawelru
Copy link
Contributor

pawelru commented Feb 26, 2024

would this work with the old version of tern? If not - we need to vbump that depedency

@edelarua
Copy link
Contributor Author

would this work with the old version of tern? If not - we need to vbump that depedency

@pawelru it will still work with the old version of tern - this isn't a breaking change but will produce deprecation warnings.

@pawelru
Copy link
Contributor

pawelru commented Feb 26, 2024

would this work with the old version of tern? If not - we need to vbump that depedency

@pawelru it will still work with the old version of tern - this isn't a breaking change but will produce deprecation warnings.

awesome. Therefore we don't need to vbump it. Thanks for checking.

@edelarua edelarua requested a review from shajoezhu February 27, 2024 20:32
Melkiades
Melkiades approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily for this update ;)

@Melkiades Melkiades dismissed shajoezhu’s stale review February 28, 2024 09:18

NEWS.md has been updated

@edelarua edelarua merged commit 064fcac into main Feb 28, 2024
24 checks passed
@edelarua edelarua deleted the 1080_strat_deprec@main branch February 28, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@shajoezhu shajoezhu Awaiting requested review from shajoezhu

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates after deprecation of strat in tern
4 participants
@edelarua @pawelru @shajoezhu @Melkiades