Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: tm_g_lineplot still uses tern::control_summarize_vars which was defunct recently. #1113

Closed
3 tasks done
vedhav opened this issue Apr 9, 2024 · 1 comment · Fixed by #1115
Closed
3 tasks done
Assignees
Labels
bug Something isn't working sme

Comments

@vedhav
Copy link
Contributor

vedhav commented Apr 9, 2024

What happened?

The tm_g_lineplot() failed when using the dev version of tern because control_summarize_vars was defunct.

This is probably already tracked. Just wanted to log this in case we did not track it. Please feel free to close this issue if the deprecation is tracked in another issue.

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@vedhav vedhav added bug Something isn't working sme labels Apr 9, 2024
@averissimo
Copy link
Contributor

This seems like a simple change if we're not propagating the name difference here.

diff --git a/R/tm_g_lineplot.R b/R/tm_g_lineplot.R
index 807a66113..fe50c3b71 100644
--- a/R/tm_g_lineplot.R
+++ b/R/tm_g_lineplot.R
@@ -156,7 +156,7 @@ template_g_lineplot <- function(dataname = "ANL",
       y_lab = ggplot2_args_ylab,
       legend_title = ggplot2_args_legend_title,
       ggtheme = ggplot2::theme_minimal(),
-      control = control_summarize_vars(conf_level = conf_level),
+      control = control_analyze_vars(conf_level = conf_level),
       subtitle_add_paramcd = FALSE,
       subtitle_add_unit = FALSE
     ),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants