Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporter_cleaning #175

Merged
merged 4 commits into from
Jul 27, 2022
Merged

reporter_cleaning #175

merged 4 commits into from
Jul 27, 2022

Conversation

mhallal1
Copy link
Collaborator

part of insightsengineering/teal.reporter#88, insightsengineering/teal.reporter#120 and insightsengineering/teal.slice#56

  • Use UI and SRV from simple_reporter
  • Remove adding title for Filter state and Show R code

@mhallal1 mhallal1 added the core label Jul 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        336     336  0.00%    217-615
R/tm_g_gh_correlationplot.R                544     544  0.00%    284-936
R/tm_g_gh_density_distribution_plot.R      266     266  0.00%    163-475
R/tm_g_gh_lineplot.R                       527     527  0.00%    185-803
R/tm_g_gh_scatterplot.R                    226     226  0.00%    163-439
R/tm_g_gh_spaghettiplot.R                  242     242  0.00%    228-524
R/toggleable_slider.R                      141     141  0.00%    82-239
R/utils.R                                  315     315  0.00%    2-504
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2598    2598  0.00%

Results for commit: 700436f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@nikolas-burkoff nikolas-burkoff self-assigned this Jul 22, 2022
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup good

@mhallal1 mhallal1 merged commit 721473d into main Jul 27, 2022
@mhallal1 mhallal1 deleted the 120_append_fs_title@main branch July 27, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants