Skip to content

Commit

Permalink
Remove lookup-refs, vbump dependencies + add Remotes (#332)
Browse files Browse the repository at this point in the history 
Part of insightsengineering/coredev-tasks#609

From now on, we will provide development dependencies in 
```
Remotes: repo/project@branch
```
format, so it's explicitly visible in the DESCRIPTION file and can be
handled by `pak::install`, `renv::install` and `remotes::install`.

With development dependencies specified in CJ Pipelines configuration,
this connection was hidden, and it was hard to install the package from
the main branch (or any other branch) locally from user's machine.

---------

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
@m7pr @github-actions
m7pr and github-actions[bot] authored Feb 4, 2025
1 parent 0cce32e commit 002a67f
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 172 deletions.
60 changes: 0 additions & 60 deletions .github/workflows/check.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,6 @@ jobs:
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
r-cmd-non-cran:
name: R CMD Check (non-CRAN) 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
Expand All @@ -79,21 +64,6 @@ jobs:
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
coverage:
name: Coverage 📔
uses: insightsengineering/r.pkg.template/.github/workflows/test-coverage.yaml@main
Expand All @@ -103,21 +73,6 @@ jobs:
additional-env-vars: |
NOT_CRAN=true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
linter:
if: github.event_name != 'push'
name: SuperLinter 🦸‍♀️
Expand All @@ -130,21 +85,6 @@ jobs:
with:
auto-update: true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
gitleaks:
name: gitleaks 💧
uses: insightsengineering/r.pkg.template/.github/workflows/gitleaks.yaml@main
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/docs.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,3 @@ jobs:
default-landing-page: latest-tag
additional-unit-test-report-directories: unit-test-report-non-cran
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
60 changes: 0 additions & 60 deletions .github/workflows/release.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,6 @@ jobs:
with:
default-landing-page: latest-tag
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
validation:
name: R Package Validation report 📃
needs: release
Expand All @@ -40,21 +25,6 @@ jobs:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
release:
name: Create release 🎉
uses: insightsengineering/r.pkg.template/.github/workflows/release.yaml@main
Expand All @@ -80,21 +50,6 @@ jobs:
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
coverage:
name: Coverage 📔
needs: [release, docs]
Expand All @@ -105,21 +60,6 @@ jobs:
additional-env-vars: |
NOT_CRAN=true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
wasm:
name: Build WASM packages 🧑‍🏭
needs: release
Expand Down
32 changes: 0 additions & 32 deletions .github/workflows/scheduled.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,22 +58,6 @@ jobs:
)
name: revdepcheck ↩️
uses: insightsengineering/r.pkg.template/.github/workflows/revdepcheck.yaml@main
with:
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
rhub:
if: >
github.event_name == 'schedule' || (
Expand All @@ -82,19 +66,3 @@ jobs:
)
name: R-hub 🌐
uses: insightsengineering/r.pkg.template/.github/workflows/rhub.yaml@main
with:
lookup-refs: |
insightsengineering/goshawk
insightsengineering/teal
insightsengineering/teal.transform
insightsengineering/teal.code
insightsengineering/teal.logger
insightsengineering/teal.reporter
insightsengineering/teal.widgets
insightsengineering/teal.slice
insightsengineering/formatters
insightsengineering/rtables
insightsengineering/rtables.officer
insightsengineering/nestcolor
insightsengineering/teal.data
insightsengineering/tern
12 changes: 7 additions & 5 deletions DESCRIPTION
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ Imports:
shinyjs,
shinyvalidate,
stats,
teal.code (>= 0.5.0.9022),
teal.logger (>= 0.3.0.9004),
teal.reporter (>= 0.3.1.9023),
teal.widgets (>= 0.4.2.9025)
teal.code (>= 0.6.0),
teal.logger (>= 0.3.1),
teal.reporter (>= 0.4.0),
teal.widgets (>= 0.4.3)
Suggests:
knitr (>= 1.42),
nestcolor (>= 0.1.0),
Expand All @@ -66,7 +66,9 @@ VignetteBuilder:
knitr,
rmarkdown
Remotes:
insightsengineering/goshawk
insightsengineering/goshawk,
insightsengineering/teal,
insightsengineering/teal.transform
Config/Needs/verdepcheck: insightsengineering/goshawk, rstudio/shiny,
insightsengineering/teal, insightsengineering/teal.slice,
insightsengineering/teal.transform, mllg/checkmate,
Expand Down

0 comments on commit 002a67f

Please sign in to comment.