Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teal.data - bs345 - fluidPage #100

Merged
merged 16 commits into from
Sep 27, 2022
Merged

teal.data - bs345 - fluidPage #100

merged 16 commits into from
Sep 27, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Sep 9, 2022 •
edited
Loading

linked to insightsengineering/teal#719

When shiny app theme is updated all fluidPage inside another fluidPage should to have the same theme.

@Polkas Polkas added the core label Sep 9, 2022
@Polkas Polkas mentioned this pull request Sep 13, 2022
Closed
Polkas
Polkas commented Sep 13, 2022
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
Polkas
Polkas commented Sep 13, 2022
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
Polkas
Polkas commented Sep 13, 2022
View reviewed changes
R/utils.R Outdated Show resolved Hide resolved
@Polkas Polkas mentioned this pull request Sep 16, 2022
Closed
@Polkas Polkas marked this pull request as ready for review September 19, 2022 08:03
Polkas
Polkas commented Sep 19, 2022
View reviewed changes
R/utils.R Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022 •
edited
Loading

Unit Tests Summary

       1 files       27 suites   1m 27s ⏱️
   320 tests    320 ✔️ 0 💤 0 ❌
1 102 runs  1 102 ✔️ 0 💤 0 ❌

Results for commit 18acfc4.

♻️ This comment has been updated with latest results.

mhallal1
mhallal1 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@mhallal1 mhallal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asbates
Copy link
Contributor

asbates commented Sep 22, 2022

LGTM

@donyunardi
Copy link
Contributor

donyunardi commented Sep 24, 2022 •
edited
Loading

The button lost its background color for selected theme:

1. TealDataConnector

with options("teal.bs_theme" = bslib::bs_theme(version = 5, bootswatch = "lux")) setup.

The button looks fine when run using other bootswatch themes.

2. TealDatasetConnector

with options("teal.bs_theme" = bslib::bs_theme(version = 5)) setup.

The button looks fine if I pass a bootswatch theme.

These could be minor issue (theme related).
Everything else looks good to me.

@donyunardi donyunardi self-requested a review September 27, 2022 00:21
@donyunardi donyunardi merged commit 25cfde2 into main Sep 27, 2022
@donyunardi donyunardi deleted the 709_bs345@main branch September 27, 2022 21:30
@donyunardi donyunardi mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donyunardi donyunardi donyunardi approved these changes

@mhallal1 mhallal1 mhallal1 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Polkas @asbates @donyunardi @mhallal1