Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve join docs #92

Merged
merged 6 commits into from
Nov 17, 2022
Merged

improve join docs #92

merged 6 commits into from
Nov 17, 2022

Conversation

donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Nov 11, 2022

closes #71
move docs from check_joinable to join methods and improve documentation.

move docs from check_joinable to join methods and improve documentation.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------
R/chunk.R                  150       3  98.00%   363-369
R/chunks.R                 416      41  90.14%   334, 424, 430-433, 439, 459, 466-467, 484-491, 500, 506-515, 561, 587, 593-594, 596, 612, 621, 630, 672, 675, 699-704, 1070, 1092, 1149, 1202
R/get_eval_details.R       118     118  0.00%    17-188
R/include_css_js.R           7       7  0.00%    12-19
R/qenv-constructor.R        12       0  100.00%
R/qenv-eval_code.R          48       2  95.83%   89, 98
R/qenv-get_code.R           16       0  100.00%
R/qenv-get_var.R            17       0  100.00%
R/qenv-get_warnings.R       14       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-show.R                4       0  100.00%
R/utils.R                   24      19  20.83%   13, 17-38
TOTAL                      872     190  78.21%

Diff against main

Filename    Stmts    Miss    Cover
----------  -------  ------  -------
TOTAL       -        -       -

Results for commit: 6a31ad4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

Unit Tests Summary

    1 files    10 suites   3s ⏱️
  98 tests   98 ✔️ 0 💤 0
414 runs  414 ✔️ 0 💤 0

Results for commit af0bf96.

♻️ This comment has been updated with latest results.

@donyunardi donyunardi linked an issue Nov 11, 2022 that may be closed by this pull request
@donyunardi donyunardi requested a review from Polkas November 14, 2022 15:30
R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Show resolved Hide resolved
R/qenv-join.R Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
R/qenv-join.R Show resolved Hide resolved
R/qenv-join.R Outdated Show resolved Hide resolved
donyunardi and others added 4 commits November 14, 2022 17:36
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Signed-off-by: Dony Unardi <donyunardi@gmail.com>
Co-authored-by: Maciej Nasinski <nasinski.maciej@gmail.com>
Signed-off-by: Dony Unardi <donyunardi@gmail.com>
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me see my comment inline if you want to act on it

R/qenv-join.R Show resolved Hide resolved
@nikolas-burkoff nikolas-burkoff self-assigned this Nov 16, 2022
@donyunardi donyunardi merged commit 49b13d2 into main Nov 17, 2022
@donyunardi donyunardi deleted the 71_improve_join_docs@main branch November 17, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document list of exceptions from joining qenv objects
3 participants