Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qenv: return NULL when var not found #82

Merged
merged 3 commits into from
Oct 25, 2022
Merged

qenv: return NULL when var not found #82

merged 3 commits into from
Oct 25, 2022

Conversation

mhallal1
Copy link
Contributor

closes #57

Returns NULL when variable not found in qenv or with qenv-error when calling get_var or [[var]].

@mhallal1 mhallal1 added the core label Oct 21, 2022
@mhallal1 mhallal1 changed the base branch from main to teal_refactor@main October 21, 2022 13:20
@mhallal1 mhallal1 marked this pull request as ready for review October 21, 2022 13:20
nikolas-burkoff
nikolas-burkoff previously requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think that qenv.error's behaviour should not be changed only qenv's @gogonzo ?

Edit: I've fixed this

@nikolas-burkoff nikolas-burkoff merged commit 96c01bd into teal_refactor@main Oct 25, 2022
@nikolas-burkoff nikolas-burkoff deleted the 57_null_get_var@teal_refactor@main branch October 25, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas-burkoff nikolas-burkoff nikolas-burkoff left review comments

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quosure - get operator should return a NULL for nomatch
2 participants
@mhallal1 @nikolas-burkoff