Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop #244

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix infinite loop #244

merged 3 commits into from
Feb 4, 2025

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Feb 4, 2025

closes insightsengineering/teal#1474

Problem happens when two or more symbols occur in the same time on rhs and lhs. Due to this, l depends on class and class depends on l.

  code <- "l <- list(a = 1, b = 2)
    class(l) <- c('new class', class(l))" # l depends on class and class depends on l
  q <- eval_code(qenv(), code)
  get_code(q, names = "l")

@donyunardi This was a serious bug and will require a new release. We can wait a little to the day when teal is going to be submitted to CRAN.

@gogonzo gogonzo added the core label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Tests Summary

  1 files   12 suites   3s ⏱️
152 tests 149 ✅ 3 💤 0 ❌
232 runs  229 ✅ 3 💤 0 ❌

Results for commit 5cb2a95.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv_get_code 👶 $+0.02$ extracting_code_doesn_t_fail_when_lhs_contains_two_or_more_symbols_occurring_in_rhs

Results for commit fcc1af1

♻️ This comment has been updated with latest results.

Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Signed-off-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @gogonzo

thanks @chlebowa for raising

@gogonzo gogonzo merged commit 93a3e31 into main Feb 4, 2025
29 checks passed
@gogonzo gogonzo deleted the teal-1474_infinite_recursion branch February 4, 2025 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Transformer enters infinite recursion when lapply used to transform data.
3 participants