Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] failing eval_code breaks the shiny app #59

Closed
Tracked by #45
gogonzo opened this issue Aug 30, 2022 · 1 comment · Fixed by #65
Closed
Tracked by #45

[BUG] failing eval_code breaks the shiny app #59

gogonzo opened this issue Aug 30, 2022 · 1 comment · Fixed by #65
Assignees
Labels
bug Something isn't working core

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Aug 30, 2022

When eval_code fails quosure is not returned anymore. It means that reactive which fails return error and breaks the whole app. What we actually need is to still return the quosure and keep the error messages (and warnings) per code element to print the proper diagnostics.
If we decide to drop diagnostics feature some tryCatch is still needed, because reactives still should return quosure and instead of error message we would like to use validate(q3) in shiny apps.

q1 <- new_quosure()
q2 <- eval_code(q1, iris2 <- iris)

q3 <- eval_code(q2, stop("elo"))
q3[["iris2"]]
r1 <- reactive(new_quosure())
r2 <- reactive(eval_code(r1(), iris2 <- iris))

r3 <- reactive(r2(), stop("elo"))

get_code(r3()) # get_code fails as r3 doesn't return quosure anymore

Final acceptance criteria not yet formulated

@nikolas-burkoff

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants