Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tt_at_path and adding test coverage to error in sorting #994

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix tt_at_path and adding test coverage to error in sorting #994

wants to merge 7 commits into from

Conversation

Melkiades
Copy link
Contributor

Fixes #864 but not sorting. That would need a similar handling as now in tt_at_path

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Unit Tests Summary

    1 files     28 suites   1m 41s ⏱️
  223 tests   223 ✅ 0 💤 0 ❌
1 591 runs  1 591 ✅ 0 💤 0 ❌

Results for commit 32d5691.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Accessing and subsetting tables 👶 $+0.31$ tt_at_path_works_with_identical_split_names
sorting and pruning 👶 $+0.17$ sort_at_path_throws_an_error_when_trying_to_sort_a_table_with_identical_branching_names

Results for commit 5138469

♻️ This comment has been updated with latest results.

@Melkiades Melkiades enabled auto-merge (squash) February 7, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua Awaiting requested review from edelarua edelarua is a code owner

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce uniqueness of sibling names in row space
1 participant
@Melkiades