Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the detailed coverage table in PR comment optional #43

Merged
merged 8 commits into from
May 14, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented May 14, 2024

Example.
Closes #42

@walkowif walkowif requested a review from a team as a code owner May 14, 2024 14:01
Copy link

github-actions bot commented May 14, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

Copy link

github-actions bot commented May 14, 2024

badge

Code Coverage Summary (test-no-branch.xml)

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------
Main.java                            11       0  100.00%
search/BinarySearch.java             12       1  91.67%   24
search/ISortedArraySearch.java        0       0  100.00%
search/LinearSearch.java              7       2  71.43%   19-24
TOTAL                                30       3  90.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a6dafaa

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented May 14, 2024

badge

Code Coverage Summary (test-missing-lines.xml)

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  ---------------
all_lines_covered.py       10       0  100.00%
miss_at_start.py           10       2  80.00%   1-3
miss_at_end.py             10       2  80.00%   9-10
single_line_gaps.py        10       3  70.00%   3, 5, 9
multi_line_gaps.py         10       7  30.00%   4-5, 7-9, 15-18
unsorted_lines.py          10       5  50.00%   4, 3, 8-9, 6
no_lines.py                 0       0  0.00%
single_line.py              1       1  0.00%    4
TOTAL                      61      20  51.25%

Results for commit: a6dafaa

Minimum allowed coverage is 50%

♻️ This comment has been updated with latest results

@walkowif
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

walkowif and others added 3 commits May 14, 2024 16:01
…thub.com:insightsengineering/coverage-action into add-parameter-to-publish-only-diff-as-pr-comment
action.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add a test case for this also? See other test workflows (they come from a matrix).

Copy link

github-actions bot commented May 14, 2024

badge

Code Coverage Summary (test-no-branch.xml) without detailed coverage

Results for commit: a6dafaa

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented May 14, 2024

badge

Code Coverage Summary (test-missing-lines.xml) without detailed coverage

Results for commit: a6dafaa

Minimum allowed coverage is 50%

♻️ This comment has been updated with latest results

Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walkowif walkowif merged commit 2ffe6eb into main May 14, 2024
10 checks passed
@walkowif walkowif deleted the add-parameter-to-publish-only-diff-as-pr-comment branch May 14, 2024 15:06
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add a way to publish only the diff
2 participants