Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PR head SHA #29

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Get PR head SHA #29

merged 3 commits into from
Oct 3, 2023

Conversation

tzing
Copy link
Contributor

@tzing tzing commented Oct 3, 2023

In PR, github.sha does not point to the head commit. It's a merge commit id that is not created by human.

Example: e26c145 in message vs latest commit 7ae5bce

Screenshot 2023-10-03 at 9 06 29 PM

This causes that results for commit: xxxxxx line always not match the commit in PR. And this PR introduces a workaround for this issue.

@tzing tzing requested a review from a team as a code owner October 3, 2023 13:09
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the fix!

action.yml Show resolved Hide resolved
Signed-off-by: cicdguy <26552821+cicdguy@users.noreply.github.com>
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
Signed-off-by: cicdguy <26552821+cicdguy@users.noreply.github.com>
@cicdguy cicdguy merged commit 36a0fea into insightsengineering:main Oct 3, 2023
1 of 5 checks passed
@cicdguy
Copy link
Contributor

cicdguy commented Oct 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants