-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow more statistics in cfbt01 template #552
Conversation
🧪 Code Coverage Summary
Diff against main
Results for commit: a4831a6f59cb441b7683a563330a74992ae1e34a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work for me, although the function is a bit slow, (it was already slow before). Very small comments inside. Thank you for the work. Any comment @barnett11
Co-authored-by: b_falquet <64274616+BFalquet@users.noreply.github.com> Signed-off-by: Liming <36079400+clarkliming@users.noreply.github.com>
Co-authored-by: b_falquet <64274616+BFalquet@users.noreply.github.com> Signed-off-by: Liming <36079400+clarkliming@users.noreply.github.com>
Co-authored-by: b_falquet <64274616+BFalquet@users.noreply.github.com> Signed-off-by: Liming <36079400+clarkliming@users.noreply.github.com>
blocked by insightsengineering/tern#983 update: this PR won't be merged in the up coming release so let's do without that PR |
Extra summary statistics seems to be working well, but I'm getting an error if I try to select summaryvars to be just |
@barnett11 it is now fixed, could you please have a look? |
Looks perfect thanks! |
I ll wait for insightsengineering/tern#983 to review since it might impact us. |
let's proceed with this because that PR won't be merged in the next release (happenning in sprint 3; date confirmed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, I am pleased to see that the baseline and screening are back in the snapshot
baseline are removed in the snapshot, screening are not (can be removed through |
close #551
I feel that cfbt01 is becoming slower....