Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding round5() to perform standard rounding, which is now the default #77

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Dec 14, 2023

What changes are proposed in this pull request?
The round5() function has been added and it now used in the default formatters. The round5() does not perform round-to-even, rather the standard type of rounding when 5s round up.

If there is an GitHub issue associated with this pull request, please provide link.
closes #69


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: devtools::install_dev_deps()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg changed the title Adding round2() to perform standard rounding, which is now the default Adding round5() to perform standard rounding, which is now the default Dec 14, 2023
@ddsjoberg ddsjoberg merged commit 2930640 into main Dec 14, 2023
9 checks passed
@ddsjoberg ddsjoberg deleted the round2 branch December 14, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do about rounding?
1 participant