Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PR Template #76

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
**What changes are proposed in this pull request?**
_Put in a format suitable to be copied into `NEWS.md`, e.g. '* I made an update. (#23)'_


**If there is an GitHub issue associated with this pull request, please provide link.**
_For example, 'closes #23'_


--------------------------------------------------------------------------------

Reviewer Checklist (if item does not apply, mark is as complete)

- [ ] Ensure all package dependencies are installed: `devtools::install_dev_deps()`
- [ ] PR branch has pulled the most recent updates from master branch: `usethis::pr_merge_main()`
- [ ] If a bug was fixed, a unit test was added.
- [ ] Run `pkgdown::build_site()`. Check the R console for errors, and review the rendered website.
- [ ] Code coverage is suitable for any new functions/features: `devtools::test_coverage()`
- [ ] `usethis::use_spell_check()` runs with no spelling errors in documentation

When the branch is ready to be merged into master:
- [ ] Update `NEWS.md` with the changes from this pull request under the heading "`# cards (development version)`". If there is an issue associated with the pull request, reference it in parentheses at the end update (see `NEWS.md` for examples).
- [ ] Increment the version number using `usethis::use_version(which = "dev")`
- [ ] Run `usethis::use_spell_check()` again
- [ ] Approve Pull Request
- [ ] Merge the PR. Please use "Squash and merge".
14 changes: 14 additions & 0 deletions tests/testthat/test-ard_categorical.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ test_that("ard_categorical() univariate", {
),
dplyr::tibble()
)

# works for ordered factors
expect_equal(
ard_categorical(
mtcars |> dplyr::mutate(cyl = factor(cyl, ordered = TRUE)),
variables = cyl
) |>
dplyr::select(stat_name, stat_label, statistic),
ard_categorical(
mtcars |> dplyr::mutate(cyl = factor(cyl, ordered = FALSE)),
variables = cyl
) |>
dplyr::select(stat_name, stat_label, statistic)
)
})

test_that("ard_categorical() univariate & specified denomiator", {
Expand Down
Loading