Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ard_categorical(statistics) argument #61

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Adding ard_categorical(statistics) argument #61

merged 7 commits into from
Dec 7, 2023

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Dec 7, 2023 •
edited
Loading

  • Added ard_categorical(statistics) argument.
  • Added function categorical_variable_summary_fns() and made it the default value for ard_categorical(statistics).
  • The variable-level statistics regarding missingness are no longer returned by default in ard_continuous() and ard_categorical().
  • Added function ard_missing() to tabulate statistics related to missingness. The default statistics returned are from the new function variable_level_summary_fns(): 'N_obs', 'N_miss', 'N_nonmiss', 'p_miss', 'p_nonmiss'.

closes #59

@ddsjoberg ddsjoberg requested a review from bzkrouse December 7, 2023 03:53
bzkrouse
bzkrouse approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@bzkrouse bzkrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liking the consistent syntax between functions! All seems good to me, I just have a couple of questions related to the variable-level summaries.

R/summary_functions.R Outdated Show resolved Hide resolved
R/summary_functions.R Show resolved Hide resolved
@ddsjoberg ddsjoberg merged commit 6e8ce0c into main Dec 7, 2023
9 checks passed
@ddsjoberg ddsjoberg deleted the categorical-statistics-argument branch December 7, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzkrouse bzkrouse bzkrouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ard_categorical(statistics=) argument
2 participants
@ddsjoberg @bzkrouse