Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating error message in rename_ard_columns() #341

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?
Error message update for rename_ard_columns(unlist) to indicate the function to call to assist with NULL values.

image

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #332


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg
Copy link
Collaborator Author

@laywang142 thank you for the suggestion! Rather than updating the NULL values for the users, we're now directing users to a function that will do it for them. I like that is keeps changing data/results intentional by the user.

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Unit Tests Summary

  1 files  164 suites   33s ⏱️
161 tests  84 ✅ 77 💤 0 ❌
311 runs  214 ✅ 97 💤 0 ❌

Results for commit 8fbf5f4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
selectors 💔 $0.03$ $+1.33$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💔 $0.09$ $+1.12$ add_calculated_row_x_
ard_continuous 💚 $3.67$ $-2.94$ ard_continuous_works
ard_hierarchical 💔 $7.97$ $+1.42$ ard_hierarchical_works_without_by_variables
print_ard_conditions 💔 $0.02$ $+1.10$ print_ard_conditions_works
selectors 💔 $0.03$ $+1.33$ selectors_work

Results for commit ff5dd25

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                 106       0  100.00%
R/ard_attributes.R                36       1  97.22%   57
R/ard_categorical.R              350      10  97.14%   238, 395-399, 406-407, 583, 617
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               178       3  98.31%   207-208, 306
R/ard_dichotomous.R               80       1  98.75%   62
R/ard_hierarchical.R              72       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_stack_hierarchical.R       232       1  99.57%   455
R/ard_stack.R                     90       1  98.89%   117
R/ard_total_n.R                   10       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      11  76.60%   74-85
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       30       0  100.00%
R/get_ard_statistics.R            16       0  100.00%
R/mock.R                         137       2  98.54%   116, 244
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          78       0  100.00%
R/print.R                         72       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R            102       1  99.02%   185
R/shuffle_ard.R                  129       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39       0  100.00%
R/update_ard.R                    53       0  100.00%
R/utils.R                         24       0  100.00%
TOTAL                           2402      42  98.25%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/shift_ard_columns.R       +1       0  +0.01%
TOTAL                       +1       0  +0.00%

Results for commit: 8fbf5f4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@ddsjoberg ddsjoberg merged commit 920ab61 into main Sep 27, 2024
33 of 35 checks passed
@ddsjoberg ddsjoberg deleted the 332-unlist-null-values branch September 27, 2024 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename_ard_columns() unlist behavior adjustment
1 participant