-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating error message in rename_ard_columns()
#341
Conversation
@laywang142 thank you for the suggestion! Rather than updating the NULL values for the users, we're now directing users to a function that will do it for them. I like that is keeps changing data/results intentional by the user. |
…ngineering/cards into 332-unlist-null-values
Unit Tests Summary 1 files 164 suites 33s ⏱️ Results for commit 8fbf5f4. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit ff5dd25 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 8fbf5f4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
What changes are proposed in this pull request?
Error message update for
rename_ard_columns(unlist)
to indicate the function to call to assist with NULL values.Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #332
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).