Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions to print conditions #322

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
#282


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Sep 16, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                 106       0  100.00%
R/ard_attributes.R                35       1  97.14%   56
R/ard_categorical.R              348      10  97.13%   233, 390-394, 401-402, 578, 612
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               176       3  98.30%   200-201, 299
R/ard_dichotomous.R               80       1  98.75%   62
R/ard_hierarchical.R              83       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_stack.R                     90       1  98.89%   117
R/ard_total_n.R                   10       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      11  76.60%   74-85
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       30       0  100.00%
R/get_ard_statistics.R            16       0  100.00%
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          78       0  100.00%
R/print.R                         72       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R             77       1  98.70%   147
R/shuffle_ard.R                  129       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39       0  100.00%
R/update_ard.R                    53       0  100.00%
R/utils.R                         24       0  100.00%
TOTAL                           2014      39  98.06%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  --------
R/eval_capture_conditions.R      +12       0  +100.00%
TOTAL                            +12       0  +0.01%

Results for commit: 55b0382

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Unit Tests Summary

  1 files  123 suites   35s ⏱️
120 tests 120 ✅ 0 💤 0 ❌
350 runs  350 ✅ 0 💤 0 ❌

Results for commit 55b0382.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_continuous 💔 $0.04$ $+5.70$ ard_continuous_works
ard_stack 💚 $5.16$ $-5.07$ ard_stack_works
eval_capture_conditions 👶 $+0.00$ captured_condition_as_error_works
eval_capture_conditions 👶 $+0.01$ captured_condition_as_message_works

Results for commit dbaf40b

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg merged commit 8697d43 into main Sep 16, 2024
19 of 27 checks passed
@ddsjoberg ddsjoberg deleted the 282-eval_condition_reporting branch September 16, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@shajoezhu shajoezhu added the sme label Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants