-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for protected names #266
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Unit Tests Summary 1 files 93 suites 28s ⏱️ Results for commit 8811208. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 27552eb ♻️ This comment has been updated with latest results. |
…ring/cards into 265_protected_names@main
Code Coverage Summary
Diff against main
Results for commit: 8811208 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just one small change and we are good to go, thank you!!
@@ -178,3 +178,11 @@ | |||
Error in `ard_categorical()`: | |||
! The `by` argument cannot include variables named "variable" and "variable_level". | |||
|
|||
# ard_categorical.survey.design(by) messages about protected names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the title/test chunk name to not reference the survey methods?
…ring/cards into 265_protected_names@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ayogasekaram !!
What changes are proposed in this pull request?
ard_continuous
andard_categorical
closes #265
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).