Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in ard_stack() when calls to functions were namespaced #250

Merged
merged 5 commits into from
May 15, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #242

@bzkrouse have you come across a method for testing if a function works if the package is not loaded? That could be a good test to add too.


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg requested a review from bzkrouse May 15, 2024 02:18
Copy link
Contributor

github-actions bot commented May 15, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  --------------------------
R/apply_fmt_fn.R                  83      16  80.72%   97-104, 186-193
R/ard_attributes.R                33       0  100.00%
R/ard_categorical.R              348      16  95.40%   223, 383-384, 540-555, 589
R/ard_complex.R                   34       0  100.00%
R/ard_continuous.R               176       4  97.73%   118, 200-201, 299
R/ard_dichotomous.R               66       2  96.97%   60, 146
R/ard_hierarchical.R              83       0  100.00%
R/ard_missing.R                   21       0  100.00%
R/ard_stack.R                     70       1  98.57%   103
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print.R                         72       0  100.00%
R/print_ard_conditions.R          75      66  12.00%   60-176
R/process_selectors.R            126       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  134       1  99.25%   268
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1717     129  92.49%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
R/ard_stack.R      +10       0  +0.24%
TOTAL              +10       0  +0.04%

Results for commit: ccc2a9c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 15, 2024

Unit Tests Summary

  1 files   87 suites   12s ⏱️
 85 tests  53 ✅ 32 💤 0 ❌
174 runs  128 ✅ 46 💤 0 ❌

Results for commit ccc2a9c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 15, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_stack 👶 $+0.01$ ard_stack_complex_call_error
ard_stack 👶 $+0.00$ ard_stack_works_with_namespaced_functions

Results for commit c714246

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@bzkrouse bzkrouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and nice solution!!

@ddsjoberg ddsjoberg merged commit d2a79a9 into main May 15, 2024
34 checks passed
@ddsjoberg ddsjoberg deleted the 242-ard_stack-namespaced-calls branch May 15, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cards::ard_stack() does not work if the cards package not attached
2 participants