-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix in ard_stack()
when calls to functions were namespaced
#250
Conversation
Code Coverage Summary
Diff against main
Results for commit: ccc2a9c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 87 suites 12s ⏱️ Results for commit ccc2a9c. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit c714246 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch and nice solution!!
What changes are proposed in this pull request?
ard_stack()
when calls to functions were namespaced. (cards::ard_stack()
does not work if the cards package not attached #242)Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #242
@bzkrouse have you come across a method for testing if a function works if the package is not loaded? That could be a good test to add too.
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).