-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting fns to generics to make them extendable #246
Conversation
Code Coverage Summary
Diff against main
Results for commit: e36f818 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 85 suites 13s ⏱️ Results for commit e36f818. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some minor checks and maybe needs more explicit documentation, otherwise LGTM!
Thank you for the review @rparmm !!! |
What changes are proposed in this pull request?
ard_*()
functions and other helpers to S3 generics to make them extendable. (Makeard_categorical()
and friends generics? #227)Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #227
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).