Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ard_heirarchicial(id) argument #229

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Adding ard_heirarchicial(id) argument #229

merged 3 commits into from
Apr 16, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Added the optional ard_heirarchicial(id) argument. When provided we check for duplicates across the column(s) supplied here. If duplicates are found, the user is warned that the percentages and denominators are not correct. (Should we add ard_stack(strata) argument? #214)

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #214


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg requested a review from bzkrouse April 16, 2024 02:13
Copy link
Contributor

github-actions bot commented Apr 16, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  68       2  97.06%   96, 176
R/ard_attributes.R                29       0  100.00%
R/ard_categorical.R              347      17  95.10%   112, 212, 372-373, 529-544, 578
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               175       4  97.71%   106, 188-189, 287
R/ard_dichotomous.R               66       2  96.97%   50, 136
R/ard_hierarchical.R              81       0  100.00%
R/ard_missing.R                   17       0  100.00%
R/ard_stack.R                     51       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           27       1  96.30%   26
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print_ard_conditions.R          75      66  12.00%   61-177
R/print.R                         72       0  100.00%
R/process_selectors.R            114       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  132       1  99.24%   267
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1644     110  93.31%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  --------
R/ard_hierarchical.R       +6       0  +100.00%
TOTAL                      +6       0  +0.02%

Results for commit: 8b979da

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Unit Tests Summary

  1 files   80 suites   12s ⏱️
 78 tests  49 ✅ 29 💤 0 ❌
164 runs  121 ✅ 43 💤 0 ❌

Results for commit 8b979da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_hierarchical 👶 $+0.01$ ard_hierarchical_id_argument_works

Results for commit 7f9f73d

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg merged commit b979552 into main Apr 16, 2024
30 checks passed
@ddsjoberg ddsjoberg deleted the 214-heirarch-ID branch April 16, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we add ard_stack(strata) argument?
2 participants