Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing snapshot that includes error text rom dplyr #228

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #225


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  63       2  96.83%   92, 172
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              347      17  95.10%   110, 205, 366-367, 525-540, 576
R/ard_complex.R                   32       0  100.00%
R/ard_continuous.R               174       4  97.70%   104, 188-189, 287
R/ard_dichotomous.R               65       2  96.92%   48, 136
R/ard_hierarchical.R              73       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/ard_stack.R                     50       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      19       1  94.74%   49
R/check_ard_structure.R           26       1  96.15%   24
R/check_pkg_installed.R           83       2  97.59%   99, 104
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            15       1  93.33%   73
R/nest_for_ard.R                  69       1  98.55%   54
R/print_ard_conditions.R          72      65  9.72%    61-178
R/print.R                         71       0  100.00%
R/process_selectors.R            110       0  100.00%
R/replace_null_statistic.R        10       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  131       1  99.24%   265
R/summary_functions.R             55       1  98.18%   89
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   38      11  71.05%   86-96
R/utils.R                         24       0  100.00%
TOTAL                           1686     110  93.48%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b1981e5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   79 suites   11s ⏱️
 77 tests  49 ✅ 28 💤 0 ❌
163 runs  121 ✅ 42 💤 0 ❌

Results for commit b1981e5.

@ddsjoberg ddsjoberg merged commit d1fd11a into main Apr 15, 2024
30 checks passed
@ddsjoberg ddsjoberg deleted the 225-err-msgs-in-snapshots branch April 15, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How best to test messages from other pkgs?
1 participant