Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for non-syntactic variable names #198

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Feb 26, 2024

Adding unit tests for non-syntactic inputs (variables, list names, etc.)
closes #170 @ayogasekaram


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Feb 26, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/apply_fmt_fn.R                  63       2  96.83%   92, 173
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              343      15  95.63%   110, 206, 520-535, 572
R/ard_complex.R                   32       0  100.00%
R/ard_continuous.R               174       4  97.70%   104, 189-190, 290
R/ard_dichotomous.R               65       2  96.92%   48, 137
R/ard_hierarchical.R              73       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/ard_stack.R                     51       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      19       1  94.74%   49
R/check_ard_structure.R           26       1  96.15%   24
R/check_pkg_installed.R           86       0  100.00%
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            15       1  93.33%   74
R/nest_for_ard.R                  69       1  98.55%   54
R/print_ard_conditions.R          72      65  9.72%    62-180
R/print.R                         71       0  100.00%
R/process_selectors.R            110       0  100.00%
R/replace_null_statistic.R        10       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  131       1  99.24%   269
R/summary_functions.R             55       1  98.18%   89
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   38      11  71.05%   86-96
R/utils.R                         24       0  100.00%
TOTAL                           1686     106  93.71%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 290ec37

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Unit Tests Summary

  1 files   78 suites   12s ⏱️
 76 tests  48 ✅ 28 💤 0 ❌
165 runs  123 ✅ 42 💤 0 ❌

Results for commit 290ec37.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_categorical 👶 $+0.01$ ard_categorical_can_handle_non_syntactic_column_names
ard_continuous 👶 $+0.00$ ard_continuous_works_with_non_syntactic_names

Results for commit b378096

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg self-requested a review March 3, 2024 18:29
@ddsjoberg ddsjoberg added the ARD label Mar 4, 2024
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you @ayogasekaram !!!

@ddsjoberg ddsjoberg merged commit 1fd52e4 into main Mar 4, 2024
30 checks passed
@ddsjoberg ddsjoberg deleted the 170_add_unit_tests@main branch March 4, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for non-syntactic column names
2 participants