Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding replace_null_statistic() #186

Merged
merged 3 commits into from
Feb 18, 2024
Merged

adding replace_null_statistic() #186

merged 3 commits into from
Feb 18, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #185


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg self-assigned this Feb 18, 2024
Copy link
Contributor

github-actions bot commented Feb 18, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/apply_statistic_fmt_fn.R        63       2  96.83%   92, 172
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              344      15  95.64%   111, 206, 518-533, 569
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               177       4  97.74%   107, 191-192, 290
R/ard_dichotomous.R               65       2  96.92%   48, 136
R/ard_hierarchical.R              73       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      19       1  94.74%   49
R/check_ard_structure.R           26       1  96.15%   24
R/check_pkg_installed.R          100       1  99.00%   157
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            15       1  93.33%   73
R/nest_for_ard.R                  69       1  98.55%   54
R/print_ard_conditions.R          72      65  9.72%    61-178
R/print.R                         71       0  100.00%
R/process_selectors.R            102       0  100.00%
R/replace_null_statistic.R        10       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  128       8  93.75%   203, 258, 262, 318-322
R/summary_functions.R             55       1  98.18%   89
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   38      11  71.05%   86-96
R/utils.R                         24       0  100.00%
TOTAL                           1643     114  93.06%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/replace_null_statistic.R      +10       0  +100.00%
TOTAL                           +10       0  +0.04%

Results for commit: 3eb8348

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 18, 2024

Unit Tests Summary

  1 files   70 suites   11s ⏱️
 68 tests  40 ✅ 28 💤 0 ❌
141 runs  100 ✅ 41 💤 0 ❌

Results for commit 3eb8348.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 18, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
replace_null_statistic 👶 $+0.09$ $+2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
replace_null_statistic 👶 $+0.09$ replace_null_statistic_works

Results for commit c7345f5

♻️ This comment has been updated with latest results.

@ddsjoberg
Copy link
Collaborator Author

hey @bzkrouse , I am going to go ahead and merge this so i can use it for something i am working on. but if you have comments/suggestions, please let me know and we can incorporate!

@ddsjoberg ddsjoberg merged commit 4ba610e into main Feb 18, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the replace-null-statistic branch February 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to fill missing calculated statistics?
1 participant