Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ard_categorical(denominator) updates for missing variables #169

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Feb 10, 2024

What changes are proposed in this pull request?

  • When there were by strata present in ard_categorical() would error when the variable was all NA, and now that scenario can be tabulated. There is also improved messaging for which all NA columns can and cannot be tabulated, i.e. only logical and factor classes can be tabulated when the entire column is missing.

closes #167


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg marked this pull request as ready for review February 10, 2024 17:11
Copy link
Contributor

github-actions bot commented Feb 10, 2024

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ----------------------
R/apply_statistic_fmt_fn.R          58       2  96.55%   92, 166
R/ard_attributes.R                  28       0  100.00%
R/ard_categorical.R                344      15  95.64%   111, 206, 518-533, 569
R/ard_complex.R                     33       0  100.00%
R/ard_continuous.R                 178       4  97.75%   107, 197-198, 296
R/ard_dichotomous.R                 65       2  96.92%   48, 136
R/ard_hierarchical.R                73       0  100.00%
R/ard_missing.R                     16       0  100.00%
R/as_nested_list.R                  41       1  97.56%   18
R/bind_ard.R                        21       1  95.24%   51
R/check_ard_structure.R             26       1  96.15%   24
R/check_pkg_installed.R            100       1  99.00%   157
R/default_stat_labels.R             18       0  100.00%
R/eval_capture_conditions.R         18       0  100.00%
R/get_ard_statistics.R              15       1  93.33%   73
R/import-standalone-stringr.R        1       0  100.00%
R/nest_for_ard.R                    69       1  98.55%   54
R/print_ard_conditions.R            72      65  9.72%    61-178
R/print.R                           69      10  85.51%   82, 91-99
R/process_selectors.R              102       0  100.00%
R/round5.R                           1       0  100.00%
R/selectors.R                       14       0  100.00%
R/shuffle_ard.R                    127       8  93.70%   202, 257, 261, 317-321
R/summary_functions.R               45       0  100.00%
R/tidy_ard_order.R                  23       0  100.00%
R/tidy_as_ard.R                     38      11  71.05%   86-96
R/utils.R                           24       0  100.00%
TOTAL                             1619     123  92.40%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/ard_categorical.R      +40       0  +0.57%
R/ard_dichotomous.R       -5      -7  +9.78%
R/utils.R                 +9       0  +100.00%
TOTAL                    +44      -7  +0.66%

Results for commit: 65579e1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 10, 2024

Unit Tests Summary

  1 files  66 suites   10s ⏱️
 64 tests 37 ✅ 27 💤 0 ❌
133 runs  93 ✅ 40 💤 0 ❌

Results for commit 65579e1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 10, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_categorical 👶 $+0.00$ ard_categorical_and_all_NA_columns
ard_categorical 👶 $+0.01$ ard_categorical_denominator_data_frame_without_counts_works
ard_categorical 💚 $2.16$ $-1.81$ ard_categorical_univariate
ard_continuous 💔 $0.10$ $+2.22$ ard_continuous_works

Results for commit af3f18c

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg requested a review from bzkrouse February 10, 2024 17:22
@ddsjoberg ddsjoberg merged commit 3c02281 into main Feb 13, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the counting-with-by-and-all-NA-vars branch February 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messaging with ard_categorical() when counting not possible
2 participants