-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 'card' print method #102
Conversation
I think this one is ready for review now, @bzkrouse ! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice!!
README.md
Outdated
#> 4 ARM Placebo AGEGR1 >80 p % 0.349 | ||
#> 5 ARM Placebo AGEGR1 65-80 n n 42 | ||
#> 6 ARM Placebo AGEGR1 65-80 p % 0.488 | ||
#> 7 ARM Placebo AGEGR1 N N 86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the readme needs re-rendering after the last update :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh good catch! thank you!
What changes are proposed in this pull request?
Adding
print.card()
method.@bzkrouse what do you think of the print method? Once we finalize, I'll finish the PR which will lead to some changes in snapshot testing I think.
What the print method does:
Reference GitHub issue associated with pull request. e.g., 'closes #1'
closes #93
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()
usethis::pr_merge_main()
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again