Bug fix: Confirm & stop the VM when the user closes the window if it is neither idle nor stopped. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundresh
commented
Aug 8, 2024
| var isStarting: Bool { | ||
| guard case .starting = state else { return false } | ||
| var isStopped: Bool { | ||
| guard case .stopped = state else { return false } | ||
| return true | ||
| } |
There was a problem hiding this comment.
Reordered to match VMState.
…is neither idle nor stopped.
sundresh
force-pushed
the
confirm_stop_vm_when_paused
branch
from
41224dd to
08389de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I can close a VM window while it's paused without being prompted whether to stop the VM. But after that, when I try to start the same VM again from the Virtual Buddy window, it's unable to start due to the error "Failed to lock auxiliary storage." That's because the paused VM was not actually stopped. This was clear because exiting and restarting Virtual Buddy does allow me to start the same VM again.
This PR changes the close VM window behavior to present the confirmation alert and (if confirmed) then stop the VM if it is in any state other than
.idleor.stoppedwhen the user attempts to close the window. (If the user interface presented the option to save the VM state while it's paused, we wouldn't need to prompt in the case the user pauses, saves, and then after the save completed, closes the window without unpausing.)