prep_fringe: load water mask into geometry file via --water-mask
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjunz
requested changes
Mar 22, 2023
+ add default water mask file value based on isce2/stripmapStack + move the isfile/exist checking to cli sub-module
yunjunz
changed the title
|
The PR looks good to me now. @bbuzz31 could you try it again to confirm if it works as you expected? |
yunjunz
changed the title
prep_fringe: load water mask into geometry file via --water-mask option
yunjunz
changed the title
prep_fringe: load water mask into geometry file via --water-mask optionprep_fringe: load water mask into geometry file via --water-mask
|
@yunjunz works for me, thanks! |
yunjunz
approved these changes
Mar 27, 2023
Great, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple change to allow watermask to be stored in geometry via prep_fringe.py.
I'm not sure how the CLI is working, but this did as expected for me.