integrate advanced time func with UQ into the routine workflow #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add the following two new template options into smallbaselineApp.cfg - mintpy.velocity.uncertaintyQuantification = residue / covariance / bootstrap, to replace the previous mintpy.velocity.bootstrap option - mintpy.velocity.timeSeriesCovFile with the default value of no + timeseries2velocity: re-use arg_group.add_reference_argument(plot=False) in timeseries2velocity.py + load_data: write S1A/B_date.txt file from SAFE_files.txt file if the latter exists in its default location (same level as reference folder)
+ integrate the advanced time func fitting into smallbaselineApp.py, via the following template options:
- mintpy.timeFunc.polynomial
- mintpy.timeFunc.periodic
- mintpy.timeFunc.step
- mintpy.timeFunc.exp
- mintpy.timeFunc.log
+ rename the following options for consistency **[BREAKING CHANGES]**:
- mintpy.velocity.excludeDate --> mintpy.timeFunc.excludeDate
- mintpy.velocity.startDate --> mintpy.timeFunc.startDate
- mintpy.velocity.endDate --> mintpy.timeFunc.endDate
- mintpy.velocity.uncertaintyQuantifiction --> mintpy.timeFunc.uncertaintyQuantification
- mintpy.velocity.timeSeriesCovFile --> mintpy.timeFunc.timeSeriesCovFile
- mintpy.velocity.bootstrapCount --> mintpy.timeFunc.bootstrapCount
+ utils.time_func.py:
- add MODEL_EXAMPLE as the single-sourced example for the time function model/configuration setup
- add inps2model() to parse/convert the namespace "inps" object into time function dict "model" object
- add get_num_param() to estimate the num of unknown parameters from a given model dict object
+ utils.readfile.read_template(): add "skip_chars" argument to skip certain characters in the template values, e.g. the commonly template typo from users "[" and "]". This is to simplify the read_template2inps() functions.
- leverage the new read_template() in following scripts:
- dem_error.py
- geocode.py
- modify_network.py
- reference_point.py
- timeseries2velocity.py
- the insarmaps-related code is removed, and they are messy and they can and should be implemented separately in insarmaps repo if needed.
+ utils.ptime.py: add get_exclude_date_list() from previous ts2vel.py
+ utils.arg_group.py:
- add_time_func_argument(): fix typo and better alignment for comments to improve the readability
- adjust indentation throughout the script
+ timeseries2velocity: support time function inputs from template files
- add time function inputs into the config keys to be saved in the h5 file
- remove the comments on contributing authors, as they are visible in the git commit history
- merge init_exp_log_dicts() and read_inps2model() into utils.time_func.inps2model()
- refactor and move read_exclude_date() into utils.ptime.get_exclude_date_list()
- read_template2inps(): support the new time function template options
- model2hdf5_dataset(): modify the periodic/exp/log dataset names, to be more clear on the time unit
+ move ifgram_reconstrunction.py to /legacy since it's not frequently used at all
+ move tropo_pyaps.py to /legacy since it's unavailable anymore (due to the takedown of EarthDef and Python2) and not actively used.
|
@yuankailiu Could you please take a look at the changes, especially the ones related to the following, and let me know if you have any suggestions?
FYI, I have the ionosphere loading with on-the-fly resizing ready for another PR once this is merged. Cheers! |
yunjunz
changed the title
yuankailiu
reviewed
Jun 17, 2022
There was a problem hiding this comment.
Hi @yunjunz, thank you for making these changes!
I have finished my review on the template file and the timeseries2velocity.py, and the time_func.py. I don't have other suggestions other than the comments I made inline. All look good to me right now.
yuankailiu
approved these changes
Jun 17, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
integrate the advanced time function fitting into
smallbaselineApp.pyvia new template options:mintpy.timeFunc.polynomialmintpy.timeFunc.periodicmintpy.timeFunc.stepmintpy.timeFunc.expmintpy.timeFunc.logintegrate the uncertainty quantification of time function parameters into
smallbaselineApp.pyvia new template options:mintpy.timeFunc.uncertaintyQuantification= residue / covariance / bootstrapmintpy.timeFunc.timeSeriesCovFile[BREAKING CHANGES] rename the previous
mintpy.velocity.*options tomintpy.timeFunc.*for consistency with the above changes.code refactoring on the following scripts to support these changes:
remove the following unused scripts to
legacydir:Reminders