add ionex.py with simplified IONEX file reading & bug fix #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ move draw_lalo_label() and draw_scalebar() from mintpy.utils.plot.py into a new sub-module mintpy.utils.map.py, for more independence. + refactor mintpy.utils.map.py + mv read_gmt_lonlat_file() from plot.py into readfile.py + remove unused plot.cmd_line_parse() + update module_hierarchiy accordingly. + mv constants from utils to objects
+ add mintpy.objects.ionex sub-module to handle all the IONEX file download/reading
- add ionex.py based on daniestevez notebook, to simplify the IONEX file reading
- move the following functions from mintpy.simulation.iono, to be more independent:
- dload_ionex()
- get_ionex_value()
- get_ionex_filename()
- get_ionex_date()
- get_ionex_height()
- plot_ionex()
- simulation.iono.py: remove the obsolete read_ionex_tec()
+ add unit test for objects/ionext.py:
- add tests/objects/ionex.py
- add tests/data/jplg3190.15i
- update .circleci/config.yml
+ update simulation.iono.py and iono_tec.py accordingly
+ update docs:
- add ionex to docs/api/module_hierarchy.md
- update .gitignore against the latest github example for python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
add
mintpy.objects.ionexmodule to simplify the IONEX file reading, and to fix a previous bug in the reading function.mintpy.simulations.ionoandmintpy.iono_tec.pytests/data(functions/modules for unit test #402)move
draw_lalo_label()anddraw_scalebar()out ofmintpy.utils.plotto form a new sub-modulemintpy.utils.map, for more independence and flexibility.move
mintpy.utils.constantsmodule tomintpy.objects.constantsview: add--ylabel-rotoption to be able to rotate y-axis label, for more compact figure in publicationReminders