replace xml.etree with defusedxml for ElementTree #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `defusedxml.ElementTree` module to replace the vulnerable `xml.etree.ElementTree` module for XML file parsing. This was used in utils.readfile.read_isce_xml() and dem_gsi.py, both of them are now either be replaced or unused. add defusedxml to dependency docs
|
Issues
======
+ Solved 2
- Added 1
See the complete overview on Codacy |
yunjunz
commented
May 9, 2020
yunjunz
added a commit
to yunjunz/MintPy
that referenced
this pull request
Nov 22, 2022
revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. insarlab#340
yunjunz
added a commit
to yunjunz/MintPy
that referenced
this pull request
Nov 22, 2022
revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. insarlab#340
yunjunz
added a commit
to yunjunz/MintPy
that referenced
this pull request
Nov 23, 2022
revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. insarlab#340
yunjunz
added a commit
that referenced
this pull request
Nov 23, 2022
* deps: drop `defusedxml`. revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. #340 * del add_attribute from setup.py and __main__.py * ionex.get_ionex_value(): rotate TEC map by default * closure_phase_bias: add link to notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
defusedxml.ElementTreemodule to replace the vulnerablexml.etree.ElementTreemodule for XML file parsing.This was used in utils.readfile.read_isce_xml() and dem_gsi.py, both of them are now either be replaced or unused.
Reminders
$MINTPY_HOME/test/test_smallbaselineApp.py