Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_gdal: switch back to gdal kwargs to leverage its subsetting capability #1072

Merged
merged 8 commits into from
Aug 19, 2023

Conversation

scottstanie
Copy link
Contributor

@scottstanie scottstanie commented Aug 18, 2023

Description of proposed changes

general quality-of-life fixes that came up while adding more GPS comparisons for UTM products (these are before those additions, it just because a big enough PR to submit)

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

The bare `next` was acting as a `pass` or `continue`
This is fixed in gdal versions >3.7.0 OSGeo/gdal#8026

The issue came from passing `np.int64` objects to GDAL, which it wasnt handling properly. Regular python `int`s work find
also fix grammar for file not found
@yunjunz yunjunz self-requested a review August 19, 2023 02:30
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thank you @scottstanie!

@yunjunz yunjunz changed the title Gps utm changes read_gdal: switch back to gdal kwargs to leverage its subsetting capability Aug 19, 2023
@scottstanie scottstanie merged commit 11a9020 into insarlab:main Aug 19, 2023
@scottstanie scottstanie deleted the gps-utm-changes branch August 19, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants