Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdfeos5: calc/write latitude/longitude if missing in geometry file #1050

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 31, 2023

Description of proposed changes

  • save_hdfeos5: always write latitude/longitude dataset, and calculate based on metadata if missing in the geometry file, such as ARIA. Related to hdfeos5: latitude/longitude missing for hyp3 product #1049.

  • cli/save_hdfeos5: check the coordinate of input file

  • improved UNIT and fig title handling for HDF-EOS5 product:

    • utils.readfile.read_attribute(): while grab the UNIT, use the last segment of dataset name if "/" is used
    • view.plot_subplot4figure(): use the last segment as the auto figure title, instead of the 2nd one, to be more generic
  • view: improved auto figsize for subplots when there is only one row of subplots

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ save_hdfeos5: always write latitude/longitude dataset, and calculate based on metadata if missing in the geometry file, such as ARIA and HyP3

+ cli/save_hdfeos5: check the coordinate of input file

+ improved UNIT and fig title handling for HDF-EOS5 product:
   - utils.readfile.read_attribute(): while grab the UNIT, use the last segment of dataset name if "/" is used
   - view.plot_subplot4figure(): use the last segment as the auto figure title, instead of the 2nd one, to be more generic

+ view: improved auto figsize for subplots when there is only one row of subplots
@yunjunz yunjunz merged commit fec802b into insarlab:main Aug 1, 2023
@yunjunz yunjunz deleted the hdfeos5_lalo branch August 1, 2023 10:54
@yunjunz yunjunz mentioned this pull request Aug 1, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant