Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read/write/resample: improved support for GDAL complex file #1000

Merged
merged 2 commits into from
May 5, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented May 5, 2023

Description of proposed changes

  • readfile:

    • read_gdal(): add .cos to the know list (for TerraSAR-X SLC data)
    • read_binary_file(): support returning complex data using datasetName=complex.
    • read_binary_file(): move cpx_band checking to expand its applicability from isce2 to generic files, including GDAL complex files.
  • resample: adjust size calculation in block-by-block IO for complex data type

  • save_gdal:

    • refactor array2raster() to write_gdal(), to be consistent with utils.writefile.write() in terms of input args.
    • use readfile.DATA_TYPE_NUMPY2GDAL to support non-float32 types, such as complex64
  • docs:

    • update Yunjun's contact email from Gmail to Outlook
    • README: simplify styles for Yunjun et al. (2019)
    • CONTRIBUTING: add links to the to-do list and roadmap

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

yunjunz added 2 commits May 5, 2023 13:39
+ update Yunjun's contact email from Gmail to Outlook

+ README: simplify styles for Yunjun et al. (2019)

+ CONTRIBUTING: add to-do list
+ readfile.read_gdal(): add .cos to the know list (for TerraSAR-X SLC data)

+ readfile.read_binary_file():
    - support returning complex data using "datasetName=complex".
    - move cpx_band checking to handle complex GDAL file

+ resample: adjust size calculation in block-by-block IO for complex data type

+ save_gdal:
   - refactor array2raster() to write_gdal(), to be consistent wit utils.writefile.write() in terms of input args.
   - use readfile.DATA_TYPE_NUMPY2GDAL to support non-float32 types, such as complex64
@yunjunz yunjunz merged commit d253b70 into insarlab:main May 5, 2023
@yunjunz yunjunz deleted the gdal branch May 5, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant