Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only depend on quickcheck* when doing a nightly build #3

Merged
merged 2 commits into from
Oct 29, 2015

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Oct 29, 2015

If these dependencies aren't optional, they will be compiled for any cargo test build, including ones with a stable compiler. This will fail, because the quickcheck_macros crate uses unstable code internally, and hence cannot be built with stable.

@huonw
Copy link
Contributor Author

huonw commented Oct 29, 2015

Eh, this fails due to rust-lang/cargo#1596.

This is where `#[quickcheck]` looks, so we better make sure it can find
it.
insanitybit added a commit that referenced this pull request Oct 29, 2015
Only depend on quickcheck* when doing a nightly build
@insanitybit insanitybit merged commit 63e0e57 into insanitybit:master Oct 29, 2015
@insanitybit
Copy link
Owner

Thanks! Confirming merge, and then I'll be moving away from using the quickcheck_macros in order to work around the last issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants