Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade workflows running on ubuntu 22.04 to 24.04 #2259

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jan 28, 2025

Content

This PR upgrade the version of ubuntu we use mainly use in our CI from 22.04 to 24.04 as this is the new default version used in github actions runners (see: actions/runner-images#10636).

There's still ubuntu 20.04 images used for some build in order to depends on a lower glibc version, there will be upgraded to 22.04 in a later PR after due announcements.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2216

@Alenar Alenar added the CI/CD 🏭 CI/CD label Jan 28, 2025
@Alenar Alenar self-assigned this Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Test Results

    4 files  ±0     52 suites  ±0   10m 27s ⏱️ -8s
1 569 tests ±0  1 569 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 843 runs  ±0  1 843 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5185743. ± Comparison against base commit a9886c5.

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/2216/ci/upgrade_to_ubuntu24 branch from 28f4a76 to 8e2d33e Compare January 28, 2025 17:58
@Alenar Alenar changed the base branch from main to djo/2252/use-tls-vendored-from-reqwest January 28, 2025 17:59
@Alenar Alenar temporarily deployed to testing-preview January 28, 2025 18:21 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet January 28, 2025 18:21 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/2252/use-tls-vendored-from-reqwest branch 2 times, most recently from 325686c to f5a37f9 Compare January 29, 2025 10:22
Base automatically changed from djo/2252/use-tls-vendored-from-reqwest to main January 29, 2025 10:52
@Alenar Alenar force-pushed the djo/2216/ci/upgrade_to_ubuntu24 branch from 2d7187a to c4af45c Compare January 29, 2025 10:56
@Alenar Alenar temporarily deployed to testing-preview January 29, 2025 11:36 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet January 29, 2025 11:36 — with GitHub Actions Inactive
@Alenar Alenar deployed to dev-preview January 29, 2025 11:44 — with GitHub Actions Active
@Alenar Alenar deployed to dev-mainnet January 29, 2025 11:44 — with GitHub Actions Active
@Alenar Alenar force-pushed the djo/2216/ci/upgrade_to_ubuntu24 branch from c4af45c to 5185743 Compare January 29, 2025 13:42
@Alenar Alenar marked this pull request as ready for review January 29, 2025 13:42
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Alenar Alenar temporarily deployed to testing-preview January 29, 2025 13:50 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet January 29, 2025 13:50 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 3b6a2a0 into main Jan 29, 2025
43 checks passed
@Alenar Alenar deleted the djo/2216/ci/upgrade_to_ubuntu24 branch January 29, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants