Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mac runner + Fix incorrect param #2019

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Upgrade mac runner + Fix incorrect param #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee11cb1
chore(ci): upgrade x86 mac runner from `macos-12` to `macos-14-large`
Alenar Oct 18, 2024
d797d46
fix(ci): use correct name for github token when building openapi ui
Alenar Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,14 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-12, macos-14, windows-latest]
os: [macos-14, macos-14-large, windows-latest]

include:
# Only build client on windows & mac
- os: macos-12
- os: macos-14
binaries-build-args: --bin mithril-client --features bundle_openssl
libraries-build-args: --package mithril-stm --package mithril-client --features full,unstable
- os: macos-14
- os: macos-14-large
binaries-build-args: --bin mithril-client --features bundle_openssl
libraries-build-args: --package mithril-stm --package mithril-client --features full,unstable
- os: windows-latest
Expand Down Expand Up @@ -169,16 +169,16 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12, macos-14, windows-latest]
os: [ubuntu-22.04, macos-14, macos-14-large, windows-latest]

include:
- os: ubuntu-22.04
test-args: --features full,unstable --workspace
# Only test client on windows & mac (since its the only binaries supported for those os for now)
- os: macos-12
test-args: --package mithril-client --package mithril-client-cli --features full,unstable
- os: macos-14
test-args: --package mithril-client --package mithril-client-cli --features full,unstable
- os: macos-14-large
test-args: --package mithril-client --package mithril-client-cli --features full,unstable
- os: windows-latest
test-args: --package mithril-client --package mithril-client-cli --features full,unstable

Expand Down Expand Up @@ -873,7 +873,7 @@ jobs:
with:
output: out/
spec-file: ./openapi.yaml
token: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish OpenAPI UI build
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12, macos-14, windows-latest]
os: [ubuntu-22.04, macos-14, macos-14-large, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout sources
Expand Down