-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance logs in mithril-relay #2014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/1981/enhance_logs_in_relay
branch
from
October 17, 2024 15:47
cb0883d
to
881e3f2
Compare
Alenar
temporarily deployed
to
testing-preview
October 17, 2024 15:55
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 17, 2024 15:55
— with
GitHub Actions
Inactive
jpraynaud
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dlachaume
approved these changes
Oct 18, 2024
Instead of passing only config parameters, this design allow to add other shared dependencies such as a common logger.
This prepare slog_scope removal
+ remove `slog_scope`, now only used in integration tests.
And instead add them to a property. This allow to keep the main log messages leans while still providing detailed errors info.
* Capitalize first letter of functionnal logs
so we are consistent accross all nodes.
* mithril-relay from `0.1.25` to `0.1.26`
Alenar
force-pushed
the
djo/1981/enhance_logs_in_relay
branch
from
October 18, 2024 09:55
de04eb0
to
a879a96
Compare
Alenar
temporarily deployed
to
testing-preview
October 18, 2024 10:13
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 18, 2024 10:13
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR refactor the log usage in
mithril-relay
:slog_scope
to enforce the usage of a name tagged child logger.Pre-submit checklist
Issue(s)
Closes #1981