Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GitHub action for creating unstable release #2007

Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 14, 2024

Content

This PR includes updates the CI jobs responsible for creating the unstable release release by replacing the unmaintained marvinpinto/action-automatic-releases action.

The https://github.com/softprops/action-gh-release now replaces both the marvinpinto/action-automatic-releases tubone24/update_release actions.

An additional step has been added to remove the previous unstable distribution and tag using the GitHub CLI's dedicated gh release delete command. This task was originally handled by the marvinpinto/action-automatic-releases action.

Example of unstable release created from a fork of Mithril using this new GitHub Action can be found here: https://github.com/dlachaume/mithril/releases/tag/unstable

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1691

@dlachaume dlachaume self-assigned this Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 27s ⏱️ +4s
1 352 tests ±0  1 352 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 560 runs  ±0  1 560 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c46682. ± Comparison against base commit 47cdaea.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

This replaces the unmaintained `marvinpinto/action-automatic-releases` action and handles the update of the release body, previously done by the `tubone24/update_release` action.
@dlachaume dlachaume force-pushed the dlachaume/1691/use-new-github-action-for-unstable-release branch from 042582c to 3c46682 Compare October 15, 2024 07:24
@dlachaume dlachaume merged commit 8fbaaee into main Oct 15, 2024
48 checks passed
@dlachaume dlachaume deleted the dlachaume/1691/use-new-github-action-for-unstable-release branch October 15, 2024 07:49
@Alenar Alenar mentioned this pull request Oct 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a new GitHub Action for creating releases
4 participants