Enhance logs construction and usage in aggregator #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use full path instead of needing a use gated by an `cfg(test)` that add noises with the other imports.
To create child logger when there's no component to hold them (such as the http server in aggregator).
* Tagged with the component name. * Existing logs are still using `slog_scope` but this prepare its removal.
… http server To tag the logs with a source so they may be easily filtered.
… services & tools To tag the logs with a source so they may be easily filtered.
Alenar
force-pushed
the
djo/1981/enhance_logs_in_aggregator
branch
from
a9f8587
to
24be951
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Oct 14, 2024
…ertificate_repository`
It's still a `dev-dependencies` as it is useful for integration tests.
Instead of the default `slog-rs`.
* mithril-aggregator from `0.5.80` to `0.5.81` * mithril-common from `0.4.67` to `0.4.68`
Alenar
force-pushed
the
djo/1981/enhance_logs_in_aggregator
branch
from
24be951
to
01bf63f
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR refactor the log usage in
mithril-aggregator:slog_scopeto enforce the usage of a name tagged child logger (only kept in the integration tests).slog-rstomithril-signer.Pre-submit checklist
Comments
As this PR is already quite big, a second PR will come that will pass over all logs in the aggregator to move away from the log message huge structure into properties, to remove prefixes in message as now all logs are tagged with their source, and to enforce a common style & structure.
Issue(s)
Relates to #1981