-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sfauvel/1990/refactor prometheus metrics using struct #1998
Sfauvel/1990/refactor prometheus metrics using struct #1998
Conversation
44573fe
to
5f32339
Compare
3090752
to
1c87643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great works !
Usage looks really nice in the signer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…`in `MetricCounter`
…xport_metrics` function create by the macro and remove `metrics_tools`
…om generic in `MetricGauge::record` function and the `round` in getter
0746b9d
to
cedeb26
Compare
* mithril-metric from `0.0.1` to `0.1.0` * mithril-common from `0.4.70` to `0.4.71` * mithril-signer from `0.2.201` to `0.2.202`
Content
Create a new crate
internal/mithril-metrics
that provide tooling to simplify the creation of a metric service.This PR includes the creation of a new crate that provide a MetricServer and a macro to simply declare a new metric service.
Pre-submit checklist
Comments
Functions to update metrics are not removed to avoid too many change in the Signer. It will be done later.
Issue(s)
Closes #1990